Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: src/IceOperand.cpp

Issue 586943003: Subzero: Change the way bitcast stack slot lowering is handled. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add clarifying comment to asType() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceOperand.h ('k') | src/IceRegAlloc.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceOperand.cpp
diff --git a/src/IceOperand.cpp b/src/IceOperand.cpp
index 1f232dd61a39b2a1332b6ee5eaced5b11271d317..e4aaf2475671163390b6b86e03d292df27e44091 100644
--- a/src/IceOperand.cpp
+++ b/src/IceOperand.cpp
@@ -189,7 +189,9 @@ IceString Variable::getName() const {
}
Variable Variable::asType(Type Ty) {
- Variable V(Ty, DefNode, Number, Name);
+ // Note: This returns a Variable, even if the "this" object is a
+ // subclass of Variable.
+ Variable V(kVariable, Ty, DefNode, Number, Name);
V.RegNum = RegNum;
V.StackOffset = StackOffset;
return V;
« no previous file with comments | « src/IceOperand.h ('k') | src/IceRegAlloc.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698