Subzero: Change the way bitcast stack slot lowering is handled.

src/IceOperand.cpp

 //===- subzero/src/IceOperand.cpp - High-level operand implementation -----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Operand class and its target-independent
@@ skipping 171 matching lines @@
 
 IceString Variable::getName() const {
   if (!Name.empty())
     return Name;
   char buf[30];
   snprintf(buf, llvm::array_lengthof(buf), "__%u", getIndex());
   return buf;
 }
 
 Variable Variable::asType(Type Ty) {
-  Variable V(Ty, DefNode, Number, Name);
+  Variable V(kVariable, Ty, DefNode, Number, Name);

[jvoung (off chromium), 2014/09/20 18:30:56]

Should it use the original Kind, instead of kVariable?

[Jim Stichnoth, 2014/09/20 19:24:53]

I don't think so, because then you could do something like
llvm::cast<VariableSpill>(&V)->getLinkedTo(), which would pass all the
compile-time and run-time checks, but would be incorrect.

I'll add a comment to clarify the limitations of asType().  BTW, hopefully we
can get rid of this sketchy function with the new assembler.

   V.RegNum = RegNum;
   V.StackOffset = StackOffset;
   return V;
 }
 
 // ======================== dump routines ======================== //
 
 void Variable::emit(const Cfg *Func) const {
   Func->getTarget()->emitVariable(this, Func);
 }
@@ skipping 64 matching lines @@
 
 Ostream &operator<<(Ostream &Str, const RegWeight &W) {
   if (W.getWeight() == RegWeight::Inf)
     Str << "Inf";
   else
     Str << W.getWeight();
   return Str;
 }
 
 } // end of namespace Ice