Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 586943002: Fix crash in protocol perf test. (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash in protocol perf test. CursorShapeStub is being called in perf tests and the test was returning NULL for the cursor stub which causes it to crash. Committed: https://crrev.com/93a39f2bcde1d6309f9fcf5ae0d0402cdc32b8af Cr-Commit-Position: refs/heads/master@{#295858}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M remoting/test/protocol_perftest.cc View 1 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-20 00:06:26 UTC) #3
rmsousa
lgtm
6 years, 3 months ago (2014-09-20 00:15:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586943002/40001
6 years, 3 months ago (2014-09-20 00:21:43 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-20 02:22:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586943002/40001
6 years, 3 months ago (2014-09-20 04:34:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 770ae77b7aadf9869abc907bf3c8982375326ebf
6 years, 3 months ago (2014-09-20 13:13:02 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 13:13:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93a39f2bcde1d6309f9fcf5ae0d0402cdc32b8af
Cr-Commit-Position: refs/heads/master@{#295858}

Powered by Google App Engine
This is Rietveld 408576698