Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 586933003: fling: Remove a bunch of code for configuring fling curves. (Closed)

Created:
6 years, 3 months ago by sadrul
Modified:
6 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, tdresser+watch_chromium.org, nasko+codewatch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, ben+aura_chromium.org, stevenjb+watch_chromium.org, jdduke (slow), tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

fling: Remove a bunch of code for configuring fling curves. The fling curve for touchpad and touchscreen used to be configurable for experimenting with, but these parameters have been stable for a long time now. So make the values default, and remove all the code and preferences that were necessary for the configurability. BUG=none R=avi@chromium.org, kenrb@chromium.org, sky@chromium.org, wjmaclean@chromium.org Committed: https://crrev.com/67feaac651ac428654a7326db2c2329d52a78de3 Cr-Commit-Position: refs/heads/master@{#296652}

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -432 lines) Patch
M chrome/browser/renderer_preferences_util.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/resources/gesture_config.js View 1 3 chunks +0 lines, -79 lines 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.cc View 7 chunks +18 lines, -65 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/salsa_ui.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/child/blink_platform_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/child/blink_platform_impl.cc View 4 chunks +2 lines, -14 lines 0 comments Download
D content/child/fling_curve_configuration.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/child/fling_curve_configuration.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M content/child/touch_fling_gesture_curve.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/child/touch_fling_gesture_curve.cc View 5 chunks +26 lines, -29 lines 0 comments Download
M content/child/touch_fling_gesture_curve_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/renderer_preferences.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/renderer_preferences.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/events/gestures/gesture_configuration.h View 3 chunks +0 lines, -11 lines 0 comments Download
M ui/events/gestures/gesture_configuration.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
sadrul
6 years, 3 months ago (2014-09-20 05:36:23 UTC) #2
wjmaclean
lgtm ... thanks for the cleanup! Curious, so I guess we never ended up using ...
6 years, 3 months ago (2014-09-22 14:11:34 UTC) #3
sadrul
On 2014/09/22 14:11:34, wjmaclean wrote: > lgtm ... thanks for the cleanup! > > Curious, ...
6 years, 3 months ago (2014-09-22 15:40:22 UTC) #4
wjmaclean
On 2014/09/22 15:40:22, sadrul wrote: > On 2014/09/22 14:11:34, wjmaclean wrote: > > lgtm ...
6 years, 3 months ago (2014-09-22 18:46:11 UTC) #5
sadrul
kenrb@chromium.org: Please review changes in content/common/view_messages.h jam@chromium.org: Please review changes in chrome/ and content/
6 years, 3 months ago (2014-09-22 19:17:27 UTC) #7
Rick Byers
On 2014/09/22 18:46:11, wjmaclean wrote: > On 2014/09/22 15:40:22, sadrul wrote: > > On 2014/09/22 ...
6 years, 3 months ago (2014-09-22 19:23:42 UTC) #8
kenrb
ipc lgtm
6 years, 3 months ago (2014-09-22 19:43:24 UTC) #9
jam
On 2014/09/22 19:17:27, sadrul wrote: > mailto:kenrb@chromium.org: Please review changes in content/common/view_messages.h > > mailto:jam@chromium.org: ...
6 years, 3 months ago (2014-09-23 05:07:19 UTC) #10
sadrul
-jam@ sky@: Please review changes in chrome/ avi@: Please review changes in content/
6 years, 3 months ago (2014-09-23 05:11:19 UTC) #13
sky
chrome LGTM
6 years, 3 months ago (2014-09-23 13:25:43 UTC) #14
sadrul
avi@: ping
6 years, 3 months ago (2014-09-24 16:03:38 UTC) #15
Avi (use Gerrit)
:O completely missed the request; thanks for the ping! content lgtm
6 years, 3 months ago (2014-09-24 16:10:42 UTC) #16
sadrul
Committed patchset #2 (id:20001) manually as 67feaac (presubmit successful).
6 years, 2 months ago (2014-09-25 05:13:11 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 05:13:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67feaac651ac428654a7326db2c2329d52a78de3
Cr-Commit-Position: refs/heads/master@{#296652}

Powered by Google App Engine
This is Rietveld 408576698