components/web_modal/web_contents_modal_dialog_manager.cc - Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.cc

Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2125

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_modal/web_contents_modal_dialog_manager.cc

diff --git a/components/web_modal/web_contents_modal_dialog_manager.cc b/components/web_modal/web_contents_modal_dialog_manager.cc

index f81a9d729cf5138994c203947ee09e331ddc0332..415926e6332ee70c6b44a60358c1bce94b26bd6b 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.cc

+++ b/components/web_modal/web_contents_modal_dialog_manager.cc

@@ -58,7 +58,7 @@ bool WebContentsModalDialogManager::IsDialogActive() const {

return !child_dialogs_.empty();

}

-void WebContentsModalDialogManager::FocusTopmostDialog() const {

+void WebContentsModalDialogManager::FocusTopmostDialog() {

DCHECK(!child_dialogs_.empty());

child_dialogs_.front()->manager->Focus();

}

« no previous file with comments | « components/web_modal/web_contents_modal_dialog_manager.h ('k') | no next file » | no next file with comments »