components/web_modal/native_web_contents_modal_dialog.h - Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/native_web_contents_modal_dialog.h

Issue 586933002: Re-Revert "[WebModals] New API for browser-scoped popup management." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2125

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_modal/native_web_contents_modal_dialog.h

diff --git a/components/web_modal/native_web_contents_modal_dialog.h b/components/web_modal/native_web_contents_modal_dialog.h

index 4bb956a8ef09010a78bb25d41b177dfa53f72c86..266e073ab9c0bfd6dcb57cdfce9071dd579458ac 100644

--- a/components/web_modal/native_web_contents_modal_dialog.h

+++ b/components/web_modal/native_web_contents_modal_dialog.h

@@ -9,8 +9,6 @@

namespace web_modal {

-// TODO(gbillock): rename this file

#if defined(OS_MACOSX)

// Use a void* since none of the gfx::Native* types are suitable for

// representing the web contents modal dialog under Cocoa.

@@ -19,14 +17,6 @@ typedef void* NativeWebContentsModalDialog;

typedef gfx::NativeView NativeWebContentsModalDialog;

#endif

-#if defined(OS_MACOSX)

-// Use a void* since none of the gfx::Native* types are suitable for

-// representing a popup window under Cocoa.

-typedef void* NativePopup;

-#else

-typedef gfx::NativeView NativePopup;

-#endif

} // namespace web_modal

#endif // COMPONENTS_WEB_MODAL_NATIVE_WEB_CONTENTS_MODAL_DIALOG_H_

« no previous file with comments | « components/web_modal.gypi ('k') | components/web_modal/popup_manager.h » ('j') | no next file with comments »