chrome/browser/sync/glue/bookmark_change_processor.cc - Issue 586913002: Add BookmarkUndoService to Android build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_change_processor.cc

Issue 586913002: Add BookmarkUndoService to Android build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: suspend undo service during sync changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/bookmark_change_processor.cc

diff --git a/chrome/browser/sync/glue/bookmark_change_processor.cc b/chrome/browser/sync/glue/bookmark_change_processor.cc

index 4a4b701a8aa1ee193dea52b50b69587d065b0ade..ae0e854ab6b1481d461a8162089cf931aa7765a1 100644

--- a/chrome/browser/sync/glue/bookmark_change_processor.cc

+++ b/chrome/browser/sync/glue/bookmark_change_processor.cc

@@ -530,9 +530,7 @@ void BookmarkChangeProcessor::ApplyChangesFromSyncModel(

model->RemoveObserver(this);

// Changes made to the bookmark model due to sync should not be undoable.

-#if !defined(OS_ANDROID)

ScopedSuspendBookmarkUndo suspend_undo(profile_);

-#endif

// Notify UI intensive observers of BookmarkModel that we are about to make

// potentially significant changes to it, so the updates may be batched. For