Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: extensions/browser/app_window/app_delegate.h

Issue 586853004: Remove AppDelegate::GetAppDefaultIcon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@not-impl
Patch Set: (app-icon) rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_delegate.h
diff --git a/extensions/browser/app_window/app_delegate.h b/extensions/browser/app_window/app_delegate.h
index 7961f2afa4d0700b43e4c56809c049b129fa3372..0e4477ec8672e061082002a7331cdea09324771b 100644
--- a/extensions/browser/app_window/app_delegate.h
+++ b/extensions/browser/app_window/app_delegate.h
@@ -9,7 +9,6 @@
#include "content/public/common/media_stream_request.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/base/window_open_disposition.h"
-#include "ui/gfx/image/image_skia.h"
namespace content {
class BrowserContext;
@@ -21,6 +20,7 @@ class WebContents;
namespace gfx {
class Rect;
+class Size;
}
namespace extensions {
@@ -69,10 +69,6 @@ class AppDelegate {
const Extension* extension) = 0;
virtual int PreferredIconSize() = 0;
- // TODO(jamescook): Eliminate this method. All implementations load the same
- // icon, and the icon is available in the extensions module resources.
- virtual gfx::ImageSkia GetAppDefaultIcon() = 0;
-
// Web contents modal dialog support.
virtual void SetWebContentsBlocked(content::WebContents* web_contents,
bool blocked) = 0;

Powered by Google App Engine
This is Rietveld 408576698