Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 586853003: Cleaning includes in SkImage-related files (Closed)

Created:
6 years, 3 months ago by Rémi Piotaix
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleaning includes in SkImage-related files BUG=skia:2948 Committed: https://skia.googlesource.com/skia/+/a29b5d8430ada72bc73b1e6e1b8f09e4b046b2ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/image/SkImagePriv.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Rémi Piotaix
PTAL
6 years, 3 months ago (2014-09-19 22:20:05 UTC) #2
tfarina
Did you try a clobber build to make sure these includes are indeed not needed? ...
6 years, 3 months ago (2014-09-20 03:07:20 UTC) #4
reed1
lgtm
6 years, 3 months ago (2014-09-22 12:52:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586853003/1
6 years, 3 months ago (2014-09-22 12:53:16 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 13:01:42 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as a29b5d8430ada72bc73b1e6e1b8f09e4b046b2ff

Powered by Google App Engine
This is Rietveld 408576698