Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2994)

Unified Diff: chrome/browser/ui/autofill/data_model_wrapper.cc

Issue 58683002: rAc: fix validation logic when autofill completion sets country (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix filling as well as validation Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/data_model_wrapper.cc
diff --git a/chrome/browser/ui/autofill/data_model_wrapper.cc b/chrome/browser/ui/autofill/data_model_wrapper.cc
index 22726546a1f8df6c1c0170f34a58c31beea6f5a6..50ef53bc285640ceb10e4daef6d57b0009300077 100644
--- a/chrome/browser/ui/autofill/data_model_wrapper.cc
+++ b/chrome/browser/ui/autofill/data_model_wrapper.cc
@@ -8,6 +8,7 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/ui/autofill/autofill_dialog_common.h"
#include "chrome/browser/ui/autofill/autofill_dialog_models.h"
#include "components/autofill/content/browser/wallet/full_wallet.h"
#include "components/autofill/content/browser/wallet/wallet_address.h"
@@ -27,7 +28,10 @@ DataModelWrapper::~DataModelWrapper() {}
void DataModelWrapper::FillInputs(DetailInputs* inputs) {
for (size_t i = 0; i < inputs->size(); ++i) {
Dan Beam 2013/11/05 02:54:43 nit: DetailInput* input = &(*inputs)[i];
- (*inputs)[i].initial_value = GetInfo(AutofillType((*inputs)[i].type));
+ (*inputs)[i].initial_value = common::GetHardcodedValueForType(
+ (*inputs)[i].type);
+ if ((*inputs)[i].initial_value.empty())
+ (*inputs)[i].initial_value = GetInfo(AutofillType((*inputs)[i].type));
}
}

Powered by Google App Engine
This is Rietveld 408576698