Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 58683002: rAc: fix validation logic when autofill completion sets country (Closed)

Created:
7 years, 1 month ago by Evan Stade
Modified:
7 years, 1 month ago
Reviewers:
Ilya Sherman, Dan Beam
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: fix validation logic when autofill completion sets country BUG=314842 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233430

Patch Set 1 #

Patch Set 2 : fix filling as well as validation #

Total comments: 2

Patch Set 3 : review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -2 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_common.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_common.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 1 chunk +58 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Evan Stade
7 years, 1 month ago (2013-11-04 23:57:20 UTC) #1
Dan Beam
so the effect of this is that the user is able to ship/bill international addresses ...
7 years, 1 month ago (2013-11-05 00:01:32 UTC) #2
Evan Stade
On 2013/11/05 00:01:32, Dan Beam wrote: > so the effect of this is that the ...
7 years, 1 month ago (2013-11-05 00:02:59 UTC) #3
Evan Stade
updated. TAL?
7 years, 1 month ago (2013-11-05 01:28:00 UTC) #4
Dan Beam
lgtm* l = &(*lgtm)[i]; https://codereview.chromium.org/58683002/diff/50001/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/58683002/diff/50001/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc#newcode507 chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:507: string16 value = full_profile.GetRawInfo(triggering_input.type); nit: ...
7 years, 1 month ago (2013-11-05 02:54:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/58683002/290001
7 years, 1 month ago (2013-11-05 04:04:05 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 04:38:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/58683002/290001
7 years, 1 month ago (2013-11-05 04:55:00 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 05:12:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/58683002/290001
7 years, 1 month ago (2013-11-05 06:01:53 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219496
7 years, 1 month ago (2013-11-05 10:07:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/58683002/290001
7 years, 1 month ago (2013-11-05 18:01:36 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219866
7 years, 1 month ago (2013-11-05 21:46:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/58683002/290001
7 years, 1 month ago (2013-11-05 22:19:53 UTC) #14
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-06 03:27:54 UTC) #15
Evan Stade
7 years, 1 month ago (2013-11-07 00:22:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 manually as r233430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698