Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 586813004: Remove debugging code which affects behavior in stable in FrameCaptionButtonContainerView (Closed)

Created:
6 years, 3 months ago by pkotwicz
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove debugging code which affects behavior in stable in FrameCaptionButtonContainerView Remove 'feature' where the animations get slowed down when a user clicks one of the window controls (minimize, maximize, close) while holding shift. This is intended for debugging only but affects behavior in stable too BUG=None TEST=None Committed: https://crrev.com/f233c99e57076f6c5604fc5ccb5474204c83a5d8 Cr-Commit-Position: refs/heads/master@{#296023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
Oshima, can you please take a look? I do not think that this debugging feature ...
6 years, 3 months ago (2014-09-20 02:33:15 UTC) #2
oshima
lgtm
6 years, 3 months ago (2014-09-22 17:05:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586813004/1
6 years, 3 months ago (2014-09-22 18:14:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0aa657f620bb0df69cd10a70df3f7c9dc1654418
6 years, 3 months ago (2014-09-22 19:09:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 19:10:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f233c99e57076f6c5604fc5ccb5474204c83a5d8
Cr-Commit-Position: refs/heads/master@{#296023}

Powered by Google App Engine
This is Rietveld 408576698