Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 586813003: Couple of tweaks to analyze exclusion list. (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
Nico, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Couple of tweaks to analyze exclusion list. BUG=416124 TEST=none R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/e2caef887beee7c8cb3298461611d00044be4d73 Cr-Commit-Position: refs/heads/master@{#295787}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M testing/buildbot/trybot_analyze_config.json View 1 chunk +2 lines, -1 line 3 comments Download

Messages

Total messages: 8 (1 generated)
sky
6 years, 3 months ago (2014-09-19 21:36:01 UTC) #1
jam
lgtm
6 years, 3 months ago (2014-09-19 21:37:06 UTC) #2
sky
Committed patchset #1 (id:1) manually as e2caef8 (presubmit successful).
6 years, 3 months ago (2014-09-19 21:37:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2caef887beee7c8cb3298461611d00044be4d73 Cr-Commit-Position: refs/heads/master@{#295787}
6 years, 3 months ago (2014-09-19 21:37:29 UTC) #4
Nico
Thanks! https://codereview.chromium.org/586813003/diff/1/testing/buildbot/trybot_analyze_config.json File testing/buildbot/trybot_analyze_config.json (right): https://codereview.chromium.org/586813003/diff/1/testing/buildbot/trybot_analyze_config.json#newcode27 testing/buildbot/trybot_analyze_config.json:27: "tools/clang/scripts/update.sh", Should these be in base too? These ...
6 years, 3 months ago (2014-09-19 21:49:56 UTC) #6
sky
https://codereview.chromium.org/586813003/diff/1/testing/buildbot/trybot_analyze_config.json File testing/buildbot/trybot_analyze_config.json (right): https://codereview.chromium.org/586813003/diff/1/testing/buildbot/trybot_analyze_config.json#newcode27 testing/buildbot/trybot_analyze_config.json:27: "tools/clang/scripts/update.sh", On 2014/09/19 21:49:56, Nico (hiding) wrote: > Should ...
6 years, 3 months ago (2014-09-22 15:51:22 UTC) #7
Nico
6 years, 3 months ago (2014-09-22 15:53:08 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/586813003/diff/1/testing/buildbot/trybot_anal...
File testing/buildbot/trybot_analyze_config.json (right):

https://codereview.chromium.org/586813003/diff/1/testing/buildbot/trybot_anal...
testing/buildbot/trybot_analyze_config.json:27: "tools/clang/scripts/update.sh",
On 2014/09/22 15:51:22, sky wrote:
> On 2014/09/19 21:49:56, Nico (hiding) wrote:
> > Should these be in base too? These 3 are logically in the same group as the
> > CMakeLists.txt file above.
> 
> Do they effect android_webview?

hm? This list here is for chromium, the one containing
tools/clang/blink_gc_plugin/CMakeLists.txt is for base.
tools/clang/blink_gc_plugin/CMakeLists.txt in theory can affect all
compilations, like the three files listed here; in practice I suppose it only
affects things in blink.

Powered by Google App Engine
This is Rietveld 408576698