Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 586793003: Safebrowsing: Honor the metadata from malware fullhash results in SB API 3.0. (Closed)

Created:
6 years, 3 months ago by mattm
Modified:
6 years, 3 months ago
Reviewers:
sky, noé
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Safebrowsing: Honor the metadata from malware fullhash results in SB API 3.0. BUG=176648 Committed: https://crrev.com/022138b539a8e8d11c5a93c159335dadba6c51aa Cr-Commit-Position: refs/heads/master@{#296116}

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : changes for sky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -46 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle.h View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle.cc View 5 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/database_manager.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 7 chunks +23 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/database_manager_unittest.cc View 1 chunk +8 lines, -3 lines 0 comments Download
A chrome/browser/safe_browsing/metadata.proto View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 2 chunks +111 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/test/data/safe_browsing/malware.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
mattm
6 years, 3 months ago (2014-09-19 23:07:11 UTC) #4
noé
lgtm Very nice CL! Thanks for taking care of that so quickly Matt! Thanks, noé.
6 years, 3 months ago (2014-09-22 18:15:32 UTC) #5
mattm
+sky for chrome/browser/* OWNERS
6 years, 3 months ago (2014-09-22 19:55:40 UTC) #7
sky
LGTM https://codereview.chromium.org/586793003/diff/20001/chrome/browser/renderer_host/safe_browsing_resource_throttle.h File chrome/browser/renderer_host/safe_browsing_resource_throttle.h (right): https://codereview.chromium.org/586793003/diff/20001/chrome/browser/renderer_host/safe_browsing_resource_throttle.h#newcode132 chrome/browser/renderer_host/safe_browsing_resource_throttle.h:132: bool is_subframe_; nit: const (same may go for ...
6 years, 3 months ago (2014-09-22 21:37:28 UTC) #8
mattm
https://codereview.chromium.org/586793003/diff/20001/chrome/browser/renderer_host/safe_browsing_resource_throttle.h File chrome/browser/renderer_host/safe_browsing_resource_throttle.h (right): https://codereview.chromium.org/586793003/diff/20001/chrome/browser/renderer_host/safe_browsing_resource_throttle.h#newcode132 chrome/browser/renderer_host/safe_browsing_resource_throttle.h:132: bool is_subframe_; On 2014/09/22 21:37:27, sky wrote: > nit: ...
6 years, 3 months ago (2014-09-22 22:22:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586793003/60001
6 years, 3 months ago (2014-09-22 22:24:17 UTC) #11
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-23 00:25:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586793003/60001
6 years, 3 months ago (2014-09-23 00:27:17 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001) as 98c16a65667bc948a4fcf89250e32768f3f2f14f
6 years, 3 months ago (2014-09-23 01:05:52 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 01:06:37 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/022138b539a8e8d11c5a93c159335dadba6c51aa
Cr-Commit-Position: refs/heads/master@{#296116}

Powered by Google App Engine
This is Rietveld 408576698