Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 586783003: webui: change all <include/> to <include>. Same thing, less bits. (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, shishir+watch_chromium.org, nhiroki, eroman, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, mmenke, Vitaly Pavlenko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

webui: change all <include/> to <include>. Same thing, less bits. R=estade@chromium.org BUG=393873 Committed: https://chromium.googlesource.com/chromium/src/+/775670bf6f5f3989ce4f303c1031b98936abb054

Patch Set 1 #

Patch Set 2 : revert print_preview, axe some whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -128 lines) Patch
M chrome/browser/resources/app_list/speech_manager.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/app_list/start_page.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/app_list/start_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/main_scripts.js View 1 chunk +28 lines, -28 lines 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +21 lines, -21 lines 0 comments Download
M chrome/browser/resources/net_internals/index.js View 1 chunk +51 lines, -51 lines 0 comments Download
M chrome/browser/resources/net_internals/top_bar_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/predictors/predictors.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/predictors/predictors.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/sync_file_system_internals/main.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/sync_internals/index.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Beam
6 years, 3 months ago (2014-09-19 22:07:09 UTC) #1
Evan Stade
lgtm
6 years, 3 months ago (2014-09-19 22:20:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586783003/20001
6 years, 3 months ago (2014-09-19 22:22:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12307)
6 years, 3 months ago (2014-09-19 22:40:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12307)
6 years, 3 months ago (2014-09-19 22:41:11 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/775670bf6f5f3989ce4f303c1031b98936abb054 Cr-Commit-Position: refs/heads/master@{#295812}
6 years, 3 months ago (2014-09-19 23:41:01 UTC) #9
Dan Beam
6 years, 3 months ago (2014-09-19 23:41:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 775670b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698