Issue 586683002: mojo: fix python unittests.

Issue 586683002: mojo: fix python unittests. (Closed)

Created:
6 years, 3 months ago by qsr

Modified:
6 years, 3 months ago

Reviewers:
sdefresne

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: fix python unittests. TBR=sdefresne@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/80ced42d624a1eec8e8a2f0c0c760ab576d65ead

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/public/python/mojo/bindings/descriptor.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/80ced42d624a1eec8e8a2f0c0c760ab576d65ead Cr-Commit-Position: refs/heads/master@{#295685}

6 years, 3 months ago (2014-09-19 10:15:43 UTC) #2

qsr

Committed patchset #1 (id:1) manually as 80ced42 (presubmit successful).

6 years, 3 months ago (2014-09-19 10:15:47 UTC) #3

vasilii

6 years, 3 months ago (2014-09-19 12:23:20 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/587653003/ by vasilii@chromium.org.

The reason for reverting is: Linux Tests mojo_python_bindings_tests failure
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712

======================================================================
ERROR: testDefaultsTestSerializationDeserialization
(bindings_serialization_deserialization_unittest.SerializationDeserializationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py",
line 125, in testDefaultsTestSerializationDeserialization
    v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles)
  File
"/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py",
line 113, in Deserialize
    serialization_object.Deserialize(fields, data, handles)
  File
"/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py",
line 82, in Deserialize
    (_, version) = HEADER_STRUCT.unpack_from(data)
TypeError: unpack_from() argument 1 must be string or read-only buffer, not
bytearray
.

Expand Messages | Collapse Messages