Issue 586673002: Use the initial map of the Object function for empty object literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 586673002: Use the initial map of the Object function for empty object literals (Closed)

Created:
6 years, 3 months ago by Toon Verwaest

Modified:
6 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Use the initial map of the Object function for empty object literals BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24088

Patch Set 2 : Make unused properties of Object be inobject #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
M	src/bootstrapper.cc	View	1	3 chunks	+10 lines, -6 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Toon Verwaest

Made unused properties of Object be inobject. PTAL again. https://codereview.chromium.org/586673002/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/586673002/diff/20001/src/hydrogen.cc#newcode11219 src/hydrogen.cc:11219: ...

6 years, 3 months ago (2014-09-19 12:27:57 UTC) #3

Toon Verwaest

6 years, 3 months ago (2014-09-19 13:40:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24088 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 586673002: Use the initial map of the Object function for empty object literals (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make unused properties of Object be inobject #

Messages