Fix last_range != range_for_next_append_ DCHECK in SourceBufferStream.

Fix last_range != range_for_next_append_ DCHECK in SourceBufferStream.

Added a condition to avoid the DCHECK for a valid situation where the
check should have been applied.. A test was added to capture the
specific case that was triggering the DCHECK.

BUG=303413
TEST=SourceBufferStreamTest.Remove_PreviousAppendDestroyedAndOverwriteExistingRange

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232998

[scherkus (not reviewing), 2013-11-05 01:39:32]

lgtm w/ nit

https://codereview.chromium.org/58663003/diff/1/media/filters/source_buffer_s...
File media/filters/source_buffer_stream_unittest.cc (right):

https://codereview.chromium.org/58663003/diff/1/media/filters/source_buffer_s...
media/filters/source_buffer_stream_unittest.cc:3229:
TEST_F(SourceBufferStreamTest,
Remove_PreviousAppendDestroyedAndOverwriteExistingRange) {
fix 80 chars

[xhwang, 2013-11-05 01:54:16]

lgtm % nit

https://codereview.chromium.org/58663003/diff/1/media/filters/source_buffer_s...
File media/filters/source_buffer_stream_unittest.cc (right):

https://codereview.chromium.org/58663003/diff/1/media/filters/source_buffer_s...
media/filters/source_buffer_stream_unittest.cc:3246: // starts at the beginning
of the range range left over from the
drop one "range"?

[xhwang, 2013-11-05 02:14:39]

I also tested the patch and it's working :)

[acolwell GONE FROM CHROMIUM, 2013-11-05 02:35:27]

https://codereview.chromium.org/58663003/diff/1/media/filters/source_buffer_s...
File media/filters/source_buffer_stream_unittest.cc (right):

https://codereview.chromium.org/58663003/diff/1/media/filters/source_buffer_s...
media/filters/source_buffer_stream_unittest.cc:3229:
TEST_F(SourceBufferStreamTest,
Remove_PreviousAppendDestroyedAndOverwriteExistingRange) {
On 2013/11/05 01:39:32, scherkus wrote:
> fix 80 chars

Done.

https://codereview.chromium.org/58663003/diff/1/media/filters/source_buffer_s...
media/filters/source_buffer_stream_unittest.cc:3246: // starts at the beginning
of the range range left over from the
On 2013/11/05 01:54:16, xhwang wrote:
> drop one "range"?

Done.

[commit-bot: I haz the power, 2013-11-05 02:41:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/58663003/90001

[commit-bot: I haz the power, 2013-11-05 03:31:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/58663003/90001

[commit-bot: I haz the power, 2013-11-05 06:20:59]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 06:50:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/58663003/90001

[commit-bot: I haz the power, 2013-11-05 16:12:09]

Change committed as 232998