Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 586623002: Cleanup: Remove remaining generated extensions APIs on Android. (try 2) (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, James Su, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove remaining generated extensions APIs on Android. (try 2) BUG=305852 Committed: https://crrev.com/e33aa2424c781e6bf76b0c37298a1a177e6818c3 Cr-Commit-Position: refs/heads/master@{#296067}

Patch Set 1 : Reverted CL #

Patch Set 2 : Cleanup GN files #

Patch Set 3 : fix build #

Patch Set 4 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -119 lines) Patch
M apps/BUILD.gn View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M apps/apps.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc View 6 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 6 chunks +44 lines, -44 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 6 chunks +9 lines, -10 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/schemas.gni View 1 1 chunk +8 lines, -14 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 5 chunks +14 lines, -2 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 3 2 chunks +3 lines, -7 lines 0 comments Download
M extensions/common/BUILD.gn View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M extensions/common/api/schemas.gni View 1 1 chunk +1 line, -5 lines 0 comments Download
M extensions/common/api/schemas.gypi View 3 chunks +3 lines, -5 lines 0 comments Download
M extensions/extensions.gyp View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
Trying again. All the try jobs are clobber try jobs. Android GN failed, but that's ...
6 years, 3 months ago (2014-09-19 18:30:19 UTC) #2
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-09-22 21:27:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586623002/60001
6 years, 2 months ago (2014-09-22 21:33:28 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001) as c587e7efa66c81c2b4b5f9797ddd49aa1158ebaa
6 years, 2 months ago (2014-09-22 22:16:39 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-22 22:17:28 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e33aa2424c781e6bf76b0c37298a1a177e6818c3
Cr-Commit-Position: refs/heads/master@{#296067}

Powered by Google App Engine
This is Rietveld 408576698