Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 586563002: Display "<1%" instead of 0% on the battery usage display. (Closed)

Created:
6 years, 3 months ago by Daniel Nishi
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
scheib, chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Display "<1%" instead of "0%" on the battery usage display. Committed: https://crrev.com/95a7656a619fc58b20e28b9a266b6ae78b8005e3 Cr-Commit-Position: refs/heads/master@{#296096}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Whoops! Reversed GE and LE. #

Patch Set 3 : Escape the character. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Daniel Nishi
bauerb: PTAL!
6 years, 3 months ago (2014-09-19 00:46:18 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/586563002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/586563002/diff/1/chrome/app/generated_resources.grd#newcode7988 chrome/app/generated_resources.grd:7988: + >1% Do you want "< 1%"? Also, ...
6 years, 3 months ago (2014-09-19 08:25:28 UTC) #3
Daniel Nishi
https://codereview.chromium.org/586563002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/586563002/diff/1/chrome/app/generated_resources.grd#newcode7988 chrome/app/generated_resources.grd:7988: + >1% On 2014/09/19 08:25:27, Bernhard Bauer wrote: > ...
6 years, 3 months ago (2014-09-19 16:23:47 UTC) #4
Bernhard Bauer
LGTM
6 years, 3 months ago (2014-09-19 16:26:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586563002/20001
6 years, 3 months ago (2014-09-19 16:44:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/10568) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/16707) ios_rel_device ...
6 years, 3 months ago (2014-09-19 16:48:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586563002/40001
6 years, 3 months ago (2014-09-19 20:25:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586563002/40001
6 years, 3 months ago (2014-09-19 20:25:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11442)
6 years, 3 months ago (2014-09-19 21:00:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586563002/40001
6 years, 3 months ago (2014-09-22 23:39:24 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 85b80957a498368d54483cb6ea3197b52370c681
6 years, 3 months ago (2014-09-22 23:44:45 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 23:45:12 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95a7656a619fc58b20e28b9a266b6ae78b8005e3
Cr-Commit-Position: refs/heads/master@{#296096}

Powered by Google App Engine
This is Rietveld 408576698