Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 586533005: Add a "mode" tag to key in DM json output. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add a "mode" tag to key in DM json output. This lets us distinguish the original ("direct") runs from their replay modes. There was a bit of a bug in here now fixed: we used the first entry in fSuffixes as the config. Actually, the last entry in suffixes is the config. This is moot when there's only one suffix (direct drawing), but for mode drawing we were recording the mode as config! Now it's correct. Here's some example output where I rigged a bunch of modes to fail: { "results" : [ { "key" : { "config" : "565", "mode" : "default-nobbh", "name" : "xfermodes2" }, "md5" : "2daf6f7e2b8e56543b92068a10d2179e", "options" : { "source_type" : "GM" } }, { "key" : { "config" : "8888", "mode" : "default-nobbh", "name" : "xfermodes2" }, "md5" : "490361e8a52800d29558bc23876da8c6", "options" : { "source_type" : "GM" } }, ... { "key" : { "config" : "565", "mode" : "direct", "name" : "xfermodes2" }, "md5" : "92a3801d5914d6c2662904a3bb50d2b9", "options" : { "source_type" : "GM" } }, ... { "key" : { "config" : "8888", "mode" : "direct", "name" : "xfermodes2" }, "md5" : "e7e8b3e9d31e601acaaff4633ed5f63a", "options" : { "source_type" : "GM" } }, BUG=skia: Committed: https://skia.googlesource.com/skia/+/87e2437fe574a5ed76caa225c4ff6464641ef64f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M dm/DMWriteTask.cpp View 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
Just noticed this while looking at Florin's failures.
6 years, 3 months ago (2014-09-19 17:21:07 UTC) #2
jcgregorio
On 2014/09/19 17:21:07, mtklein wrote: > Just noticed this while looking at Florin's failures. LGTM
6 years, 3 months ago (2014-09-19 17:26:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586533005/1
6 years, 3 months ago (2014-09-19 17:27:53 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 17:35:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 87e2437fe574a5ed76caa225c4ff6464641ef64f

Powered by Google App Engine
This is Rietveld 408576698