Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 586533003: Enable app.window.shape on Stable channel (again). (Closed)

Created:
6 years, 3 months ago by garykac
Modified:
6 years, 3 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable app.window.shape on Stable channel (again). Remove the Stable whitelist. BUG=324071, 374440 Committed: https://crrev.com/0394320b458343d2ce133403f479c344fffaeb06 Cr-Commit-Position: refs/heads/master@{#295878}

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -53 lines) Patch
M extensions/common/api/_permission_features.json View 1 1 chunk +4 lines, -53 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
garykac
6 years, 3 months ago (2014-09-18 22:39:55 UTC) #2
garykac
For reference, this is the previous cl where we moved this API to Stable: https://codereview.chromium.org/453173002/
6 years, 3 months ago (2014-09-19 18:34:02 UTC) #3
miket_OOO
lgtm
6 years, 3 months ago (2014-09-19 19:17:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586533003/1
6 years, 3 months ago (2014-09-19 21:19:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586533003/1
6 years, 3 months ago (2014-09-19 21:19:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/69165) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/58456) win_gpu ...
6 years, 3 months ago (2014-09-19 21:24:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586533003/20001
6 years, 3 months ago (2014-09-19 23:48:42 UTC) #11
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-20 01:50:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586533003/20001
6 years, 3 months ago (2014-09-20 16:56:41 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6fcc6672821aed7e061360908bf36d0c2aad1156
6 years, 3 months ago (2014-09-20 16:57:01 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 16:57:36 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0394320b458343d2ce133403f479c344fffaeb06
Cr-Commit-Position: refs/heads/master@{#295878}

Powered by Google App Engine
This is Rietveld 408576698