Issue 586493002: Fix media crash in layout test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 586493002: Fix media crash in layout test (Closed)

Created:
6 years, 3 months ago by boliu

Modified:
6 years, 3 months ago

Reviewers:
qinmin

CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix media crash in layout test Layout test do not use compositor thread, so WebMediaPlayerAndroid ends up using a null message loop. BUG=412578 Committed: https://crrev.com/3df2bcc24f973c2c53f37b288fa1b5191c10bd45 Cr-Commit-Position: refs/heads/master@{#295596}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	content/renderer/media/android/webmediaplayer_android.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586493002/1

6 years, 3 months ago (2014-09-18 21:35:41 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as c045969f3488c3e5d874654dc3579f0fe05ca881

6 years, 3 months ago (2014-09-18 23:20:53 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 23:22:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3df2bcc24f973c2c53f37b288fa1b5191c10bd45
Cr-Commit-Position: refs/heads/master@{#295596}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages