Issue 586473002: Restore old behavior of SkTypeface::CreateFromTypeface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 586473002: Restore old behavior of SkTypeface::CreateFromTypeface. (Closed)

Created:
6 years, 3 months ago by bungeman-skia

Modified:
6 years, 3 months ago

Reviewers:
caryclark

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	src/core/SkTypeface.cpp	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
	M	src/ports/SkFontMgr_fontconfig.cpp	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

bungeman-skia

The issue appears to be that a recent refactor did not properly move all of ...

6 years, 3 months ago (2014-09-18 20:41:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/586473002/20001

6 years, 3 months ago (2014-09-18 20:44:12 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 20:57:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as b14e4a0db5cb1b96cef5236585ee4572c5d95b97