Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issue 586463002: remove no-op override (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove no-op override NOTREECHECKS=True NOTRY=True Committed: https://skia.googlesource.com/skia/+/abfaf63bd0331fb8f20b7ef47b384fcb39418669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/iOSShell.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/586463002/1
6 years, 3 months ago (2014-09-18 20:33:41 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-18 20:33:42 UTC) #4
egdaniel
lgtm
6 years, 3 months ago (2014-09-18 20:33:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/586463002/1
6 years, 3 months ago (2014-09-18 20:36:02 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 20:36:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as abfaf63bd0331fb8f20b7ef47b384fcb39418669

Powered by Google App Engine
This is Rietveld 408576698