Skip MetricsReportingEnabled test

Skip MetricsReportingEnabled test

As code for MetricsReportingEnabled checkbox has been refactored not to use pref in HTML, it is not possibly to test the policy enforcement with the current test (codereview.chromium.org/506663003).

Therefore we skip MetricsReportingEnabled test to have a quick solution for failing bots, until a new test will be created.

Also, just because I was touching this file I fixed OFFICIAL_BUILD to be GOOGLE_CHROME_BUILD(discussed in crbug.com/399462).

BUG=414945
Committed: https://crrev.com/1fce1ab55d2128dcb3bcf9945b4c8b388a354484
Cr-Commit-Position: refs/heads/master@{#295720}

[gayane -on leave until 09-2017, 2014-09-18 20:42:38]

Patchset #1 (id:1) has been deleted

[gayane -on leave until 09-2017, 2014-09-18 20:48:22]

gayane@chromium.org changed reviewers:
+ asvitkine@chromium.org, bartfab@chromium.org

[Alexei Svitkine (slow), 2014-09-18 20:55:35]

LGTM

Please also link to your previous CL that did the refactoring from this CL's
description for context.

[bartfab (slow), 2014-09-19 14:56:37]

https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
File chrome/browser/policy/policy_prefs_browsertest.cc (right):

https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
chrome/browser/policy/policy_prefs_browsertest.cc:619: continue;
The correct thing to do is to remove the "indicator_tests" entry for
|MetricsReportingEnabled| from policy_test_cases.json, not to change the code.

[gayane -on leave until 09-2017, 2014-09-19 15:24:34]

https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
File chrome/browser/policy/policy_prefs_browsertest.cc (right):

https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
chrome/browser/policy/policy_prefs_browsertest.cc:619: continue;
On 2014/09/19 14:56:37, bartfab (OOO until 13 October) wrote:
> The correct thing to do is to remove the "indicator_tests" entry for
> |MetricsReportingEnabled| from policy_test_cases.json, not to change the code.

If I only remove test case from the json file, the assert at Line 622 will fail
because it cannot find a test case for the policy.

[gayane1, 2014-09-19 15:35:00]

Patchset #2 (id:40001) has been deleted

[gayane1, 2014-09-19 15:35:41]

gayane@google.com changed reviewers:
+ gayane@google.com

[gayane1, 2014-09-19 15:35:41]

https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
File chrome/browser/policy/policy_prefs_browsertest.cc (right):

https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
chrome/browser/policy/policy_prefs_browsertest.cc:619: continue;
On 2014/09/19 15:24:33, gayane wrote:
> On 2014/09/19 14:56:37, bartfab (OOO until 13 October) wrote:
> > The correct thing to do is to remove the "indicator_tests" entry for
> > |MetricsReportingEnabled| from policy_test_cases.json, not to change the
code.
> 
> If I only remove test case from the json file, the assert at Line 622 will
fail
> because it cannot find a test case for the policy.
> 

Ah I see, you meant not the whole test case but just indicator tests. That will
work.

[gayane -on leave until 09-2017, 2014-09-19 15:48:19]

On 2014/09/19 15:35:41, gayane1 wrote:
>
https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
> File chrome/browser/policy/policy_prefs_browsertest.cc (right):
> 
>
https://codereview.chromium.org/586453002/diff/20001/chrome/browser/policy/po...
> chrome/browser/policy/policy_prefs_browsertest.cc:619: continue;
> On 2014/09/19 15:24:33, gayane wrote:
> > On 2014/09/19 14:56:37, bartfab (OOO until 13 October) wrote:
> > > The correct thing to do is to remove the "indicator_tests" entry for
> > > |MetricsReportingEnabled| from policy_test_cases.json, not to change the
> code.
> > 
> > If I only remove test case from the json file, the assert at Line 622 will
> fail
> > because it cannot find a test case for the policy.
> > 
> 
> Ah I see, you meant not the whole test case but just indicator tests. That
will
> work.

Done.

[Alexei Svitkine (slow), 2014-09-19 15:50:48]

lgtm

[bartfab (slow), 2014-09-19 15:55:43]

lgtm

[gayane1, 2014-09-19 15:55:57]

The CQ bit was checked by gayane@google.com

[commit-bot: I haz the power, 2014-09-19 15:56:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586453002/60001

[commit-bot: I haz the power, 2014-09-19 16:55:40]

Committed patchset #2 (id:60001) as 3a21581b6b708b774afb60f41bfb8f62b7ecb7ca

[commit-bot: I haz the power, 2014-09-19 16:56:17]

Patchset 2 (id:??) landed as
https://crrev.com/1fce1ab55d2128dcb3bcf9945b4c8b388a354484
Cr-Commit-Position: refs/heads/master@{#295720}