Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 586393005: Make writeRenderTargetPixels use draw buffer rather than GrGpu (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Make writeRenderTargetPixels use draw buffer rather than GrGpu Committed: https://skia.googlesource.com/skia/+/656f2cd5588fabde2bbc2bd42763beb1347fc491

Patch Set 1 #

Patch Set 2 : cleanup, add disable for clipping #

Patch Set 3 : move comment #

Patch Set 4 : target- #

Patch Set 5 : rebase and remove flush #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M src/gpu/GrContext.cpp View 1 2 3 4 5 5 chunks +22 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bsalomon
6 years, 3 months ago (2014-09-23 15:18:49 UTC) #2
bsalomon
Updated to not flush and rebased.
6 years, 2 months ago (2014-09-26 16:57:11 UTC) #4
robertphillips
lgtm
6 years, 2 months ago (2014-09-29 12:03:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586393005/80001
6 years, 2 months ago (2014-09-29 13:55:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/1772) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1610) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot ...
6 years, 2 months ago (2014-09-29 13:59:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586393005/100001
6 years, 2 months ago (2014-09-29 17:54:48 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 18:02:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 656f2cd5588fabde2bbc2bd42763beb1347fc491

Powered by Google App Engine
This is Rietveld 408576698