Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 586383002: Add ChromeShellTestApk and other chrome/ test stuff (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tfarina, klundberg+watch_chromium.org, stgao, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-chrome-shell-apk
Project:
chromium
Visibility:
Public.

Description

Add ChromeShellTestApk and other chrome/ test stuff Adds these targets: //chrome/android:chrome_javatests //chrome/android:chrome_shell_test_java //chrome/android:chrome_shell_test_apk //chrome/android:chrome_sync_shell_test_apk //chrome/android:uiautomator_tests_java //chrome/android:uiautomator_tests //chrome/test/android:chrome_java_test_support //chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_apk //chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_resources depends on https://codereview.chromium.org/570203002/ TBR=ben BUG=359249 Committed: https://crrev.com/4fe114e79020c97813df6d36dfb156b834749126 Cr-Commit-Position: refs/heads/master@{#299926}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Remove gn function stderr stuff #

Patch Set 5 : #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -14 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/gyp/find.py View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 3 4 5 3 chunks +107 lines, -11 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 chunks +6 lines, -0 lines 0 comments Download
A chrome/test/android/BUILD.gn View 1 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/test/webview_shell/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
M components/bookmarks.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
cjhopman
nyquist: *
6 years, 2 months ago (2014-10-13 22:16:47 UTC) #2
nyquist
lgtm would we also want to build the test-targets when building all targets to ensure ...
6 years, 2 months ago (2014-10-13 22:27:44 UTC) #3
cjhopman
TBR: ben@ for OWNERS of BUILD.gn chrome/test/chromedriver/test/webview_shell/BUILD.gn components/bookmarks.gypi
6 years, 2 months ago (2014-10-16 00:28:53 UTC) #5
cjhopman
On 2014/10/13 22:27:44, nyquist wrote: > lgtm > > would we also want to build ...
6 years, 2 months ago (2014-10-16 00:29:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586383002/120001
6 years, 2 months ago (2014-10-16 00:31:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/22619)
6 years, 2 months ago (2014-10-16 03:39:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586383002/120001
6 years, 2 months ago (2014-10-16 17:19:17 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:120001)
6 years, 2 months ago (2014-10-16 18:02:31 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 18:03:57 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4fe114e79020c97813df6d36dfb156b834749126
Cr-Commit-Position: refs/heads/master@{#299926}

Powered by Google App Engine
This is Rietveld 408576698