Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 586333003: Disable fallback support for alternative data reduction proxy (Closed)

Created:
6 years, 3 months ago by bengr
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable fallback support for alternative data reduction proxy The alternative configuration of the data reduction proxy will not include a fallback proxy. BUG=410437 Committed: https://crrev.com/2f9bd09e2c62df44ccb2d35ef0aa40712ae7ce0b Cr-Commit-Position: refs/heads/master@{#296066}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -36 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_params.h View 4 chunks +14 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_params.cc View 8 chunks +23 lines, -10 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc View 43 chunks +130 lines, -17 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bengr
marq: all
6 years, 3 months ago (2014-09-21 18:48:40 UTC) #6
marq (ping after 24h)
LGTM but I didn't go through all of the test cases.
6 years, 3 months ago (2014-09-22 08:59:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586333003/80001
6 years, 3 months ago (2014-09-22 20:28:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:80001) as bb76f5fd6ece850d72161b7a957f5fc6ae010a16
6 years, 3 months ago (2014-09-22 22:16:15 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 22:16:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f9bd09e2c62df44ccb2d35ef0aa40712ae7ce0b
Cr-Commit-Position: refs/heads/master@{#296066}

Powered by Google App Engine
This is Rietveld 408576698