Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 586213002: Fix a wrong dependency in ash/BUILD.gn (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a wrong dependency in ash/BUILD.gn BUG=None R=cmasone@chromium.org TBR=jamescook@chromium.org TEST=gn gen Committed: https://crrev.com/d4ff03fe7f9a643c21fdd06c6ba7d827e1156c34 Cr-Commit-Position: refs/heads/master@{#296031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Jun Mukai
6 years, 3 months ago (2014-09-20 00:11:19 UTC) #1
Chris Masone
lgtm
6 years, 3 months ago (2014-09-20 00:12:52 UTC) #2
Jun Mukai
On 2014/09/20 00:12:52, Chris Masone wrote: > lgtm switching jamescook to TBR because this is ...
6 years, 3 months ago (2014-09-20 00:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586213002/1
6 years, 3 months ago (2014-09-20 00:16:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586213002/1
6 years, 3 months ago (2014-09-20 00:17:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586213002/1
6 years, 3 months ago (2014-09-20 00:17:10 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-20 02:18:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586213002/1
6 years, 3 months ago (2014-09-22 20:15:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4db145c4f06cfd1a50ee0d11df7196cff7679b89
6 years, 3 months ago (2014-09-22 20:16:28 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 20:17:04 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d4ff03fe7f9a643c21fdd06c6ba7d827e1156c34
Cr-Commit-Position: refs/heads/master@{#296031}

Powered by Google App Engine
This is Rietveld 408576698