Basic implementation of GeofencingManager class.

content/browser/geofencing/geofencing_dispatcher_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geofencing/geofencing_dispatcher_host.h"
 
+#include "content/browser/geofencing/geofencing_manager.h"
 #include "content/common/geofencing_messages.h"
-#include "content/common/geofencing_status.h"
 #include "third_party/WebKit/public/platform/WebCircularGeofencingRegion.h"
 
 namespace content {
 
 static const int kMaxRegionIdLength = 200;
 
 GeofencingDispatcherHost::GeofencingDispatcherHost()
     : BrowserMessageFilter(GeofencingMsgStart) {
 }
 
@@ skipping 16 matching lines @@
     int thread_id,
     int request_id,
     const std::string& region_id,
     const blink::WebCircularGeofencingRegion& region) {
   // Sanity check on region_id
   if (region_id.length() > kMaxRegionIdLength) {
     Send(new GeofencingMsg_RegisterRegionComplete(
         thread_id, request_id, GeofencingStatus::GEOFENCING_STATUS_ERROR));
     return;
   }
-  // TODO(mek): Handle registration request.
-  Send(new GeofencingMsg_RegisterRegionComplete(
-      thread_id,
-      request_id,
-      GeofencingStatus::
-          GEOFENCING_STATUS_OPERATION_FAILED_SERVICE_NOT_AVAILABLE));
+  GeofencingManager::GetInstance()->RegisterRegion(
+      0, /* service_worker_registration_id */

[Michael van Ouwerkerk, 2014/10/06 16:43:42]

I assume you need a TODO here? And below.

[Marijn Kruisselbrink, 2014/10/06 19:14:11]

Sure, I can add more TODO's here as well, although it's not like I'm going to
forget to actually do this...

[Michael van Ouwerkerk, 2014/10/08 16:59:01]

TODO's are not just reminders for your future self: it helps your reviewers
understand whether there was an oversight or not, it saves them time and WTFs.
You want to be towards the left side of this:
http://www.osnews.com/story/19266/WTFs_m

+      region_id,
+      region,
+      base::Bind(&GeofencingDispatcherHost::RegisterRegionCompleted,
+                 this,

[Michael van Ouwerkerk, 2014/10/06 16:43:41]

Should this be a weak pointer?

[Marijn Kruisselbrink, 2014/10/06 19:14:11]

Yes, that's probably better. Done.

+                 thread_id,
+                 request_id));
 }
 
 void GeofencingDispatcherHost::OnUnregisterRegion(
     int thread_id,
     int request_id,
     const std::string& region_id) {
   // Sanity check on region_id
   if (region_id.length() > kMaxRegionIdLength) {
     Send(new GeofencingMsg_UnregisterRegionComplete(
         thread_id, request_id, GeofencingStatus::GEOFENCING_STATUS_ERROR));
     return;
   }
-  // TODO(mek): Handle unregistration request.
-  Send(new GeofencingMsg_UnregisterRegionComplete(
-      thread_id,
-      request_id,
-      GeofencingStatus::
-          GEOFENCING_STATUS_OPERATION_FAILED_SERVICE_NOT_AVAILABLE));
+  GeofencingManager::GetInstance()->UnregisterRegion(
+      0, /* service_worker_registration_id */
+      region_id,
+      base::Bind(&GeofencingDispatcherHost::UnregisterRegionCompleted,
+                 this,
+                 thread_id,
+                 request_id));
 }
 
 void GeofencingDispatcherHost::OnGetRegisteredRegions(int thread_id,
                                                       int request_id) {
   GeofencingRegistrations result;
+  GeofencingStatus status =
+      GeofencingManager::GetInstance()->GetRegisteredRegions(
+          0, /* service_worker_registration_id */
+          &result);
   Send(new GeofencingMsg_GetRegisteredRegionsComplete(
-      thread_id,
-      request_id,
-      GeofencingStatus::
-          GEOFENCING_STATUS_OPERATION_FAILED_SERVICE_NOT_AVAILABLE,
-      result));
+      thread_id, request_id, status, result));
+}
+
+void GeofencingDispatcherHost::RegisterRegionCompleted(
+    int thread_id,
+    int request_id,
+    GeofencingStatus result) {

[Michael van Ouwerkerk, 2014/10/06 16:43:41]

Let's call this status as you use result for other purposes elsewhere.

[Marijn Kruisselbrink, 2014/10/06 19:14:11]

Done.

+  Send(new GeofencingMsg_RegisterRegionComplete(thread_id, request_id, result));
+}
+
+void GeofencingDispatcherHost::UnregisterRegionCompleted(
+    int thread_id,
+    int request_id,
+    GeofencingStatus result) {
+  Send(new GeofencingMsg_UnregisterRegionComplete(
+      thread_id, request_id, result));
 }
 
 }  // namespace content