Chromium Code Reviews| Index: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java |
| diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java |
| index a0a537d041643255caee33870e96997921be1baa..c7d09cc247ec5599f10fffc3e1592829b28285a1 100644 |
| --- a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java |
| +++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java |
| @@ -4,7 +4,6 @@ |
| package org.chromium.net; |
| -import java.net.URL; |
| import java.nio.ByteBuffer; |
| /** |
| @@ -20,10 +19,11 @@ public interface UrlRequestListener { |
| * |
| * @param request Request being redirected. |
| * @param info Response information. |
| - * @param newLocation Location where request is redirected. |
| + * @param newLocationUrl Location where request is redirected. |
| */ |
| - public void onRedirect(UrlRequest request, ResponseInfo info, |
| - URL newLocation); |
| + public void onRedirect(UrlRequest request, |
| + ResponseInfo info, |
| + String newLocationUrl); |
| /** |
| * Called when the final set of headers, after all redirects, |
| @@ -41,25 +41,32 @@ public interface UrlRequestListener { |
| * Cancelling the request also invalidates the buffer. |
| * |
| * @param request Request that received data. |
| + * @param info Response information. |
| * @param byteBuffer Received data. |
| */ |
| - public void onDataReceived(UrlRequest request, ByteBuffer byteBuffer); |
| + public void onDataReceived(UrlRequest request, |
| + ResponseInfo info, |
|
xunjieli
2014/10/31 21:01:51
nit: use +8 indentation and on line 70.
|
| + ByteBuffer byteBuffer); |
| /** |
| - * Called when request is complete, no callbacks will be called afterwards. |
| + * Called when request is completed successfully, no callbacks will be |
| + * called afterwards. |
| * |
| - * @param request Request that is complete. |
| + * @param request Request that succeeded. |
| + * @param info Response information. |
| */ |
| - public void onComplete(UrlRequest request); |
| + public void onSucceeded(UrlRequest request, ExtendedResponseInfo info); |
| /** |
| - * Can be called at any point between start() and onComplete(). Once |
| + * Called if request failed for any reason after start(). Once |
| * called, no other functions can be called. UrlRequestException |
| * provides information about error. |
| * |
| - * @param request Request that received an error. |
| + * @param request Request that failed. |
| + * @param info Response information. |
| * @param error information about error. |
| */ |
| - public void onError(UrlRequest request, |
| - UrlRequestException error); |
| + public void onFailed(UrlRequest request, |
| + ResponseInfo info, |
| + UrlRequestException error); |
| } |