Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

Issue 586143002: Initial implementation of Cronet Async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments, add more shutdown tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
index a0a537d041643255caee33870e96997921be1baa..d960c48a935e6518fdbef3c7dd049ea477b32157 100644
--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
@@ -4,7 +4,6 @@
package org.chromium.net;
-import java.net.URL;
import java.nio.ByteBuffer;
/**
@@ -20,10 +19,11 @@ public interface UrlRequestListener {
*
* @param request Request being redirected.
* @param info Response information.
- * @param newLocation Location where request is redirected.
+ * @param newLocationUrl Location where request is redirected.
*/
- public void onRedirect(UrlRequest request, ResponseInfo info,
- URL newLocation);
+ public void onRedirect(UrlRequest request,
+ ResponseInfo info,
xunjieli 2014/10/31 19:57:21 Sorry my bad. Java uses +8 indentation for paramet
mef 2014/10/31 20:39:16 No worries, it looks good and presubmit style chec
+ String newLocationUrl);
/**
* Called when the final set of headers, after all redirects,
@@ -41,16 +41,20 @@ public interface UrlRequestListener {
* Cancelling the request also invalidates the buffer.
*
* @param request Request that received data.
+ * @param info Response information.
* @param byteBuffer Received data.
*/
- public void onDataReceived(UrlRequest request, ByteBuffer byteBuffer);
+ public void onDataReceived(UrlRequest request,
+ ResponseInfo info,
xunjieli 2014/10/31 19:57:21 Use +8 indentation instead.
+ ByteBuffer byteBuffer);
/**
* Called when request is complete, no callbacks will be called afterwards.
*
* @param request Request that is complete.
+ * @param info Response information.
*/
- public void onComplete(UrlRequest request);
+ public void onComplete(UrlRequest request, ExtendedResponseInfo info);
/**
* Can be called at any point between start() and onComplete(). Once
@@ -58,8 +62,10 @@ public interface UrlRequestListener {
* provides information about error.
*
* @param request Request that received an error.
+ * @param info Response information.
* @param error information about error.
*/
public void onError(UrlRequest request,
+ ResponseInfo info,
xunjieli 2014/10/31 19:57:21 Use +8 indentation instead.
UrlRequestException error);
}

Powered by Google App Engine
This is Rietveld 408576698