Initial implementation of Cronet Async API.

components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

Index: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
index a0a537d041643255caee33870e96997921be1baa..d960c48a935e6518fdbef3c7dd049ea477b32157 100644
--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
@@ -4,7 +4,6 @@
 
 package org.chromium.net;
 
-import java.net.URL;
 import java.nio.ByteBuffer;
 
 /**
@@ -20,10 +19,11 @@ public interface UrlRequestListener {
      *
      * @param request Request being redirected.
      * @param info Response information.
-     * @param newLocation Location where request is redirected.
+     * @param newLocationUrl Location where request is redirected.
      */
-    public void onRedirect(UrlRequest request, ResponseInfo info,
-                           URL newLocation);
+    public void onRedirect(UrlRequest request,
+                           ResponseInfo info,
+                           String newLocationUrl);
 
     /**
      * Called when the final set of headers, after all redirects,
@@ -41,16 +41,20 @@ public interface UrlRequestListener {
      * Cancelling the request also invalidates the buffer.
      *
      * @param request Request that received data.
+     * @param info Response information.
      * @param byteBuffer Received data.
      */
-    public void onDataReceived(UrlRequest request, ByteBuffer byteBuffer);
+    public void onDataReceived(UrlRequest request,
+                               ResponseInfo info,
+                               ByteBuffer byteBuffer);
 
     /**
      * Called when request is complete, no callbacks will be called afterwards.
      *
      * @param request Request that is complete.
+     * @param info Response information.
      */
-    public void onComplete(UrlRequest request);
+    public void onComplete(UrlRequest request, ExtendedResponseInfo info);

[mmenke, 2014/10/30 21:47:56]

What do you think of my suggestion to rename this to unambiguously indicate it's
only called on success?  My suggestion was onSuccess, but open to other ideas.

[mef, 2014/10/30 22:32:55]

I like that. I don't totally like onSuccess as it doesn't mention that it is
complete.
OTOH 'onCompleteSuccess' is a bit over the top. :)

 
     /**
      * Can be called at any point between start() and onComplete().  Once
@@ -58,8 +62,10 @@ public interface UrlRequestListener {
      * provides information about error.
      *
      * @param request Request that received an error.
+     * @param info Response information.
      * @param error information about error.
      */
     public void onError(UrlRequest request,
+                        ResponseInfo info,
                         UrlRequestException error);
 }