Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: components/cronet/android/java/src/org/chromium/net/ResponseInfo.java

Issue 586143002: Initial implementation of Cronet Async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address clm's comments, populate ResponseInfo. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
diff --git a/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java b/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
index e6679d97ec2f80d0db38f0931e7324041cf9147e..413d78592f780bd1e9a848bd769b8393a040cd3f 100644
--- a/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
+++ b/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
@@ -4,7 +4,6 @@
package org.chromium.net;
-import java.net.URL;
import java.util.List;
import java.util.Map;
@@ -17,14 +16,14 @@ public abstract interface ResponseInfo {
* Return the url the response is for (Not the original URL - after
* redirects, it's the new URL).
*/
- URL getUrl();
+ String getUrl();
/**
*
* @return the url chain, including all redirects. The originally
* requested URL is first.
*/
- URL[] getUrlChain();
+ String[] getUrlChain();
/**
* Returns the HTTP status code.
@@ -45,14 +44,9 @@ public abstract interface ResponseInfo {
boolean wasCached();
/**
- *
- * @return
- */
- boolean wasFetchedOverSPDY();
-
- /**
- *
- * @return
+ * Returns protocol (e.g. "quic/1+spdy/3") negotiated with server. Returns
+ * empty string if no protocol was negotiated, or the protocol is not known.
+ * Returns empty when using plain http or https.
*/
- boolean wasFetchedOverQUIC();
+ String getNegotiatedProtocol();
};

Powered by Google App Engine
This is Rietveld 408576698