Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

Issue 586143002: Initial implementation of Cronet Async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More tests, more comments, more cancel. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
index a0a537d041643255caee33870e96997921be1baa..5888571c3950782b62cd138594e4e44ce175f422 100644
--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
@@ -41,16 +41,19 @@ public interface UrlRequestListener {
* Cancelling the request also invalidates the buffer.
*
* @param request Request that received data.
+ * @param info Response information.
* @param byteBuffer Received data.
*/
- public void onDataReceived(UrlRequest request, ByteBuffer byteBuffer);
+ public void onDataReceived(UrlRequest request,
+ ResponseInfo info, ByteBuffer byteBuffer);
xunjieli 2014/10/23 15:51:22 nit: indent. Should ResponseInfo be at the same in
mef 2014/10/24 03:31:45 Done.
/**
* Called when request is complete, no callbacks will be called afterwards.
*
* @param request Request that is complete.
+ * @param info Response information.
*/
- public void onComplete(UrlRequest request);
+ public void onComplete(UrlRequest request, ExtendedResponseInfo info);
/**
* Can be called at any point between start() and onComplete(). Once
@@ -58,8 +61,10 @@ public interface UrlRequestListener {
* provides information about error.
*
* @param request Request that received an error.
+ * @param info Response information.
* @param error information about error.
*/
public void onError(UrlRequest request,
+ ResponseInfo info,
UrlRequestException error);
}

Powered by Google App Engine
This is Rietveld 408576698