components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java - Issue 586143002: Initial implementation of Cronet Async API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

Issue 586143002: Initial implementation of Cronet Async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/UrlRequest.java ('K') | « components/cronet/android/java/src/org/chromium/net/UrlRequestException.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

index a0a537d041643255caee33870e96997921be1baa..2e1b4ab57e569723c5d67dce0a0a1c138381fb10 100644

--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

@@ -43,7 +43,7 @@ public interface UrlRequestListener {

* @param request Request that received data.

* @param byteBuffer Received data.

- public void onDataReceived(UrlRequest request, ByteBuffer byteBuffer);

+ public void onDataReceived(UrlRequest request, final ByteBuffer byteBuffer);

Charles 2014/09/20 00:47:34 That doesn't do anything, java doesn't do referenc

mef 2014/09/22 17:12:13 Done.

/**

* Called when request is complete, no callbacks will be called afterwards.