Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 586113003: [Easy signin]Set more permit record data when converting from key device list (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
Reviewers:
xiyuan, Tim Song
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Easy signin]Set more permit record data when converting from key device list Also, fix passing tpm ket to challenge creator-> the key array contains 0x00, so standard conversion const char* -> std::string won't work. BUG=401634 Committed: https://crrev.com/511484beb31286cb7e83d4305da8d16dd54d01aa Cr-Commit-Position: refs/heads/master@{#295867}

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc View 1 3 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
tbarzic
6 years, 3 months ago (2014-09-19 22:19:51 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/586113003/diff/1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc File chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc (right): https://codereview.chromium.org/586113003/diff/1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc#newcode306 chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc:306: std::string(kTpmPubKey, arraysize(kTpmPubKey)), oops. Goog catch. :p https://codereview.chromium.org/586113003/diff/1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc File ...
6 years, 3 months ago (2014-09-19 22:26:49 UTC) #3
Tim Song
lgtm
6 years, 3 months ago (2014-09-19 23:00:48 UTC) #4
tbarzic
https://codereview.chromium.org/586113003/diff/1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc File chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc (right): https://codereview.chromium.org/586113003/diff/1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc#newcode28 chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc:28: const char kPermitTypeValue[] = "licence"; On 2014/09/19 22:26:48, xiyuan ...
6 years, 3 months ago (2014-09-19 23:59:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586113003/40001
6 years, 3 months ago (2014-09-20 02:39:31 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a1928dcc0585717eb8e95fd5ee02cece17e87391
6 years, 3 months ago (2014-09-20 13:19:10 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 13:19:52 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/511484beb31286cb7e83d4305da8d16dd54d01aa
Cr-Commit-Position: refs/heads/master@{#295867}

Powered by Google App Engine
This is Rietveld 408576698