Implement ChromeVox next/previous line, link, and heading.

ImplementChromeVox  next/previous line, link, and heading.

Committed: https://crrev.com/930fcbcccbb7a4c0c8892acf175503555099e29c
Cr-Commit-Position: refs/heads/master@{#297234}

[David Tseng, 2014-09-19 22:25:49]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org, plundblad@chromium.org

[David Tseng, 2014-09-19 22:25:50]

WIP. Just an FYI where things are heading; probably a good time to sit down and
discuss design/features/keybindings.
There are some pretty obvious bugs with syncing the current focus, but line
navigation works surprisingly well simply based on inlineTextBoxs.

[dmazzoni, 2014-09-22 06:44:26]

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js
(right):

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:113:
return ret;
nit: indent

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:154:
return e.role == 'inlineTextBox';
FWIW, since inline text boxes aren't actually nodes, I was thinking maybe they
should be abstracted from ChromeVox by the automation API. ChromeVox would just
see static text nodes, but there'd be methods to get line info.

Note that there are sometimes multiple inline text boxes per line

[Peter Lundblad, 2014-09-22 09:31:00]

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js
(right):

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:148:
current = moveNext(current, true, function(e) {
I think using predicates like this is nice.  I suggest creating a separate
utility namespace with those to make the code less verbose and more
maintainable.

[David Tseng, 2014-09-22 23:41:29]

PTAL; tests still coming (somewhat blocked on the switch over to a runtime flag
to enable ChromeVox next).

If you patch in this cl, you will notice some performance issues with the jump
commands. Will need to investigate further, but perhaps not within scope of this
cl.

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js
(right):

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:154:
return e.role == 'inlineTextBox';
On 2014/09/22 06:44:26, dmazzoni wrote:
> FWIW, since inline text boxes aren't actually nodes, I was thinking maybe they
> should be abstracted from ChromeVox by the automation API. ChromeVox would
just
> see static text nodes, but there'd be methods to get line info.
> 
> Note that there are sometimes multiple inline text boxes per line

I actually think leaving them in the tree will simplify ChromeVox code. If the
following are true, then we can base all navigation off of in-line text boxes.
- they exist as children even if a parent has no text.
- their immediate parent's role should be announced (e.g. link, heading,
listitem).

So, the rules we use would be as follows:
line navigation: simply move to the next/previous in-line textbox in depth-first
order.
go to beginning: sync (drill down) into the deepest in-line textbox.
go to end: sync (drill down) into the deepest in-line textbox (reversed/moving
right to left).
element/item navigation: move to the parent of the current in-line textbox; now,
move to the next/previous in-line textbox. Finally, return the parent.
group navigation: based upon element navigation; perhaps based on specific
roles.

on each navigation, these "nodes" could be treated in the same way in terms of
highlighting rectangles.

[David Tseng, 2014-09-22 23:45:34]

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js
(right):

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:113:
return ret;
On 2014/09/22 06:44:26, dmazzoni wrote:
> nit: indent

Done.

https://codereview.chromium.org/586103004/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:148:
current = moveNext(current, true, function(e) {
On 2014/09/22 09:30:59, Peter Lundblad wrote:
> I think using predicates like this is nice.  I suggest creating a separate
> utility namespace with those to make the code less verbose and more
> maintainable.

Done.

[David Tseng, 2014-09-23 00:54:42]

FYI; looks like setting focus on each navigation/jump command is super
expensive. Will look into this on the API side.

On Mon, Sep 22, 2014 at 4:45 PM, <dtseng@chromium.org> wrote:

>
> https://codereview.chromium.org/586103004/diff/1/chrome/
> browser/resources/chromeos/chromevox2/cvox2/background/background.js
> File
> chrome/browser/resources/chromeos/chromevox2/cvox2/
> background/background.js
> (right):
>
> https://codereview.chromium.org/586103004/diff/1/chrome/
> browser/resources/chromeos/chromevox2/cvox2/background/
> background.js#newcode113
> chrome/browser/resources/chromeos/chromevox2/cvox2/
> background/background.js:113:
> return ret;
> On 2014/09/22 06:44:26, dmazzoni wrote:
>
>> nit: indent
>>
>
> Done.
>
> https://codereview.chromium.org/586103004/diff/1/chrome/
> browser/resources/chromeos/chromevox2/cvox2/background/
> background.js#newcode148
> chrome/browser/resources/chromeos/chromevox2/cvox2/
> background/background.js:148:
> current = moveNext(current, true, function(e) {
> On 2014/09/22 09:30:59, Peter Lundblad wrote:
>
>> I think using predicates like this is nice.  I suggest creating a
>>
> separate
>
>> utility namespace with those to make the code less verbose and more
>> maintainable.
>>
>
> Done.
>
>
> https://codereview.chromium.org/586103004/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-09-23 22:18:06]

Patchset #3 (id:40001) has been deleted

[David Tseng, 2014-09-25 22:42:33]

On 2014/09/23 00:54:42, David Tseng wrote:
> FYI; looks like setting focus on each navigation/jump command is super
> expensive. Will look into this on the API side.
> 
> On Mon, Sep 22, 2014 at 4:45 PM, <mailto:dtseng@chromium.org> wrote:
> 
> >
> > https://codereview.chromium.org/586103004/diff/1/chrome/
> > browser/resources/chromeos/chromevox2/cvox2/background/background.js
> > File
> > chrome/browser/resources/chromeos/chromevox2/cvox2/
> > background/background.js
> > (right):
> >
> > https://codereview.chromium.org/586103004/diff/1/chrome/
> > browser/resources/chromeos/chromevox2/cvox2/background/
> > background.js#newcode113
> > chrome/browser/resources/chromeos/chromevox2/cvox2/
> > background/background.js:113:
> > return ret;
> > On 2014/09/22 06:44:26, dmazzoni wrote:
> >
> >> nit: indent
> >>
> >
> > Done.
> >
> > https://codereview.chromium.org/586103004/diff/1/chrome/
> > browser/resources/chromeos/chromevox2/cvox2/background/
> > background.js#newcode148
> > chrome/browser/resources/chromeos/chromevox2/cvox2/
> > background/background.js:148:
> > current = moveNext(current, true, function(e) {
> > On 2014/09/22 09:30:59, Peter Lundblad wrote:
> >
> >> I think using predicates like this is nice.  I suggest creating a
> >>
> > separate
> >
> >> utility namespace with those to make the code less verbose and more
> >> maintainable.
> >>
> >
> > Done.
> >
> >
> > https://codereview.chromium.org/586103004/
> >
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to mailto:chromium-reviews+unsubscribe@chromium.org.
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

PTAL; added a new test and some initial infrastructural support.

[dmazzoni, 2014-09-26 06:08:53]

Looking pretty good now!

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
File chrome/browser/resources/chromeos/braille_ime/OWNERS (left):

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
chrome/browser/resources/chromeos/braille_ime/OWNERS:1: aboxhall@chromium.org
Was this file deleted by mistake?

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
(right):

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:78:
cvox2.AutomationUtil.findDeepestNode = function(cur, r, pred) {
Hmmm, this doesn't really find the "deepest" node - I believe the correct
technical term is that this is a post-order traversal of the tree, the other one
is pre-order traversal.

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs
(right):

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:88:
setTimeout(this.waitForSpeech.bind(this, textStrings, opt_callback), 100);
Rather than a timeout, could you make a way to register a callback that gets
called every time there's an utterance?

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
(right):

https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js:65:
runWithDocument: function(doc, callback) {
Nice!

[David Tseng, 2014-09-26 16:33:22]

On Thu 25 Sep 2014 11:08:52 PM PDT, dmazzoni@chromium.org wrote:

 > Looking pretty good now!
 > 
 > 
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File chrome/browser/resources/chromeos/braille_ime/OWNERS (left):
 > 
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > chrome/browser/resources/chromeos/braille_ime/OWNERS:1:
 > aboxhall@chromium.org
 > Was this file deleted by mistake?
Yup; had merged in several cl's into this one. Restored.



 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
 > (right):
 > 
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:78:
 > cvox2.AutomationUtil.findDeepestNode = function(cur, r, pred) {
 > Hmmm, this doesn't really find the "deepest" node - I believe the
 > correct technical term is that this is a post-order traversal of the
 > tree, the other one is pre-order traversal.
 >
 You're right; I was semi-following the naming in dom_util.js. The more
 apt name (non-technical) is leftmost/rightmost then deepest node. Will change
to findPre/findPost.
 
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs
 > (right):
 > 
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:88:
 > setTimeout(this.waitForSpeech.bind(this, textStrings, opt_callback),
 > 100);
 > Rather than a timeout, could you make a way to register a callback that
 > gets called every time there's an utterance?
 >
Yeah; that sounds good to me. Just pass a predicate callback which I'll
wrap to call |opt_callback| if successful.

 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File
 >
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
 > (right):
 > 
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 >
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js:65:
 > runWithDocument: function(doc, callback) {
 > Nice!
 > 
 > https://codereview.chromium.org/586103004/
 > 
 > To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
 > 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-09-26 16:41:15]

On Thu 25 Sep 2014 11:08:52 PM PDT, dmazzoni@chromium.org wrote:

 > Looking pretty good now!
 >
 >
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File chrome/browser/resources/chromeos/braille_ime/OWNERS (left):
 >
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > chrome/browser/resources/chromeos/braille_ime/OWNERS:1:
 > aboxhall@chromium.org
 > Was this file deleted by mistake?
Yup; had merged in several cl's into this one. Restored.



 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
 > (right):
 >
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:78:
 > cvox2.AutomationUtil.findDeepestNode = function(cur, r, pred) {
 > Hmmm, this doesn't really find the "deepest" node - I believe the
 > correct technical term is that this is a post-order traversal of the
 > tree, the other one is pre-order traversal.
 >
 You're right; I was semi-following the naming in dom_util.js. The
intent is to find the left/rightmost deepest node. Will change to
findPre/findPost.

 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs
 > (right):
 >
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 >
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:88:
 > setTimeout(this.waitForSpeech.bind(this, textStrings, opt_callback),
 > 100);
 > Rather than a timeout, could you make a way to register a callback that
 > gets called every time there's an utterance?
 >
Yeah; that sounds good to me. Just pass a predicate callback which
will call the opt_callback if successful when received an utterance. I
could get rid of the queue of utterances in the case, but this would
potentially drop any utterances before a test calls waitForSpeech.




 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 > File
 >
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
 > (right):
 >
 >
https://codereview.chromium.org/586103004/diff/100001/chrome/browser/resource...
 >
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js:65:
 > runWithDocument: function(doc, callback) {
 > Nice!
 >
 > https://codereview.chromium.org/586103004/
 >
 > To unsubscribe from this group and stop receiving emails from it,
send an email to chromium-reviews+unsubscribe@chromium.org.
 >

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-09-26 18:26:29]

PTAL; made some improvements to the test helpers/naming.

[David Tseng, 2014-09-26 22:09:25]

Patchset #9 (id:180001) has been deleted

[dmazzoni, 2014-09-29 06:06:18]

Please add a tracking bug to this changelist. The tests are looking really good
now.

I hope you don't mind if I'm more picky about a few things, I figure it's better
to take the time to get it right while this codebase is still small.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:49:
* @param {boolean} r False to search forward (left to right), true to search
Let's make the type an enum rather than boolean, and the parameter name 'dir'
instead of 'r'. It's still very short and concise but doesn't require you to
mentall remember what direction is true or false. It also won't require 2 lines
of documentation. Here's my specific idea:

/** @enum **/
cvox.Dir = {
  FORWARDS,
  BACKWARDS
}

 * @param {cvox.Direction} dir The direction to search.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:91:
* Find the directed next node that is either an immediate sibling or a sibling
By "directed next" do you mean, either the next node, or the previous node,
depending on 'r'? I just find the wording confusing. How about: Find the next
node in the given direction that is...

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:95:
* backward (right to left).
nit: indent 4 spaces - and elsewhere for additional lines of description for the
same parameter.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:64:
idleUtterances_: [],
nit: indent 2

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:73:
* |opt_callback| is * called.
Nit: delete extra '*'

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:140:
cvox.ChromeVox.tts.expectSpeech('Status tray', testDone);
This looks much cleaner. I don't mind that the order of these is reversed.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:173:
* @param {Object} evt
Is there a specific automation api type rather than {Object}?

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:195:
* @param {Object} evt
Is there a specific automation api type rather than {Object}?

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js:6:
'chrome/browser/resources/chromeos/chromevox/testing/common.js']);
nit: indent 4

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js:67:
var url = 'data:text/html,<!doctype html><html><body>' +
nit: i wouldn't include the <html><body> here - that precludes tests from adding
a HEAD section or adding attributes to the BODY, for example - and for tests
that don't need it, leaving them off will have the same result in the html
parser anyway.

[dmazzoni, 2014-09-29 06:06:32]

lgtm with above comments addressed

[David Tseng, 2014-09-29 17:05:23]

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:91:
* Find the directed next node that is either an immediate sibling or a sibling
On 2014/09/29 06:06:17, dmazzoni wrote:
> By "directed next" do you mean, either the next node, or the previous node,
> depending on 'r'? I just find the wording confusing. How about: Find the next
> node in the given direction that is...
> 

Done.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js:95:
* backward (right to left).
On 2014/09/29 06:06:17, dmazzoni wrote:
> nit: indent 4 spaces - and elsewhere for additional lines of description for
the
> same parameter.

Done.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:64:
idleUtterances_: [],
On 2014/09/29 06:06:17, dmazzoni wrote:
> nit: indent 2

Done.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.extjs:73:
* |opt_callback| is * called.
On 2014/09/29 06:06:18, dmazzoni wrote:
> Nit: delete extra '*'

Done.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:173:
* @param {Object} evt
On 2014/09/29 06:06:18, dmazzoni wrote:
> Is there a specific automation api type rather than {Object}?

See below.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:195:
* @param {Object} evt
On 2014/09/29 06:06:18, dmazzoni wrote:
> Is there a specific automation api type rather than {Object}?

No; nothing defined on chrome.automation at least. Extension API object types
don't get defined anywhere; we could do something custom for automation (which
is what I did for the enum types).

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
(right):

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js:6:
'chrome/browser/resources/chromeos/chromevox/testing/common.js']);
On 2014/09/29 06:06:18, dmazzoni wrote:
> nit: indent 4

Done.

https://codereview.chromium.org/586103004/diff/240001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js:67:
var url = 'data:text/html,<!doctype html><html><body>' +
On 2014/09/29 06:06:18, dmazzoni wrote:
> nit: i wouldn't include the <html><body> here - that precludes tests from
adding
> a HEAD section or adding attributes to the BODY, for example - and for tests
> that don't need it, leaving them off will have the same result in the html
> parser anyway.

Done.

[David Tseng, 2014-09-29 17:10:02]

Patchset #12 (id:260001) has been deleted

[David Tseng, 2014-09-29 18:07:40]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-09-29 18:08:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586103004/320001

[David Tseng, 2014-09-29 18:13:08]

Patchset #14 (id:320001) has been deleted

[David Tseng, 2014-09-29 18:13:27]

Patchset #13 (id:300001) has been deleted

[David Tseng, 2014-09-29 18:13:40]

Patchset #12 (id:280001) has been deleted

[David Tseng, 2014-09-29 18:13:54]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2014-09-29 18:14:22]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2014-09-29 18:14:30]

Patchset #12 (id:340001) has been deleted

[David Tseng, 2014-09-29 18:33:35]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-09-29 18:34:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586103004/360001

[commit-bot: I haz the power, 2014-09-29 19:36:49]

Committed patchset #12 (id:360001) as 3c9b47e721a381174a88dbe6637f8ac23cb3ee0a

[commit-bot: I haz the power, 2014-09-29 19:37:16]

Patchset 12 (id:??) landed as
https://crrev.com/930fcbcccbb7a4c0c8892acf175503555099e29c
Cr-Commit-Position: refs/heads/master@{#297234}