Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 586073002: Don't flush on read/write pixels unless necessary (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@iotype
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Total comments: 1

Patch Set 3 : Flush when drawing direct to GrGpu in GrContext #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -9 lines) Patch
M include/gpu/GrGpuResource.h View 1 chunk +5 lines, -0 lines 0 comments Download
M include/gpu/GrSurface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 4 chunks +13 lines, -8 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bsalomon
https://codereview.chromium.org/586073002/diff/20001/include/gpu/GrGpuResource.h File include/gpu/GrGpuResource.h (right): https://codereview.chromium.org/586073002/diff/20001/include/gpu/GrGpuResource.h#newcode83 include/gpu/GrGpuResource.h:83: will remove this extra \n
6 years, 2 months ago (2014-09-22 14:41:22 UTC) #2
robertphillips
lgtm
6 years, 2 months ago (2014-09-22 14:48:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586073002/20001
6 years, 2 months ago (2014-09-22 14:55:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 150723b9298772a5096bec7acd2999c5c9d66239
6 years, 2 months ago (2014-09-22 15:17:05 UTC) #6
bsalomon
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/594543004/ by bsalomon@google.com. ...
6 years, 2 months ago (2014-09-22 16:11:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586073002/40001
6 years, 2 months ago (2014-09-22 19:07:04 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-22 19:21:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 8d034a154fec81167ecb696c07da389b98cc02a7

Powered by Google App Engine
This is Rietveld 408576698