Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 586063002: Remove orphaned Syzygy binaries on non-Windows platforms. (Closed)

Created:
6 years, 3 months ago by chrisha
Modified:
6 years, 3 months ago
CC:
chromium-reviews, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove orphaned Syzygy binaries on non-Windows platforms. This modifies the gclient hook to remove files that were inadvertently downloaded by a previous version of the script. BUG=414826 Committed: https://crrev.com/f3b3b3bbeb8ed28ffa0c7580650a1d2ef29dade2 Cr-Commit-Position: refs/heads/master@{#295763}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed siggi's nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M build/get_syzygy_binaries.py View 1 1 chunk +40 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
chrisha
PTAL?
6 years, 3 months ago (2014-09-19 18:40:20 UTC) #2
Sigurður Ásgeirsson
lgtm with but a small nit. https://codereview.chromium.org/586063002/diff/1/build/get_syzygy_binaries.py File build/get_syzygy_binaries.py (right): https://codereview.chromium.org/586063002/diff/1/build/get_syzygy_binaries.py#newcode371 build/get_syzygy_binaries.py:371: expected_syzygy_dir = os.path.abspath(os.path.join( ...
6 years, 3 months ago (2014-09-19 18:44:42 UTC) #3
chrisha
Thanks, committing. https://codereview.chromium.org/586063002/diff/1/build/get_syzygy_binaries.py File build/get_syzygy_binaries.py (right): https://codereview.chromium.org/586063002/diff/1/build/get_syzygy_binaries.py#newcode371 build/get_syzygy_binaries.py:371: expected_syzygy_dir = os.path.abspath(os.path.join( On 2014/09/19 18:44:42, Sigurður ...
6 years, 3 months ago (2014-09-19 18:48:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586063002/20001
6 years, 3 months ago (2014-09-19 18:50:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ba48479618db0528910c6b81c16fd00f9abe866b
6 years, 3 months ago (2014-09-19 19:28:05 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 19:32:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3b3b3bbeb8ed28ffa0c7580650a1d2ef29dade2
Cr-Commit-Position: refs/heads/master@{#295763}

Powered by Google App Engine
This is Rietveld 408576698