Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: util/test/mac/mach_multiprocess.cc

Issue 586053002: MachMultiprocess test: the child process must wait for the parent to finish (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Handle it in the base class Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/test/multiprocess.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/test/mac/mach_multiprocess.h" 15 #include "util/test/mac/mach_multiprocess.h"
16 16
17 #include <AvailabilityMacros.h> 17 #include <AvailabilityMacros.h>
18 #include <bsm/libbsm.h> 18 #include <bsm/libbsm.h>
19 #include <servers/bootstrap.h> 19 #include <servers/bootstrap.h>
20 20
21 #include <string> 21 #include <string>
22 22
23 #include "base/auto_reset.h" 23 #include "base/auto_reset.h"
24 #include "base/logging.h" 24 #include "base/logging.h"
25 #include "base/mac/scoped_mach_port.h" 25 #include "base/mac/scoped_mach_port.h"
26 #include "base/memory/scoped_ptr.h" 26 #include "base/memory/scoped_ptr.h"
27 #include "base/rand_util.h" 27 #include "base/rand_util.h"
28 #include "gtest/gtest.h" 28 #include "gtest/gtest.h"
29 #include "util/file/fd_io.h"
29 #include "util/mach/mach_extensions.h" 30 #include "util/mach/mach_extensions.h"
30 #include "util/misc/scoped_forbid_return.h" 31 #include "util/misc/scoped_forbid_return.h"
31 #include "util/test/errors.h" 32 #include "util/test/errors.h"
32 #include "util/test/mac/mach_errors.h" 33 #include "util/test/mac/mach_errors.h"
33 34
34 namespace { 35 namespace {
35 36
36 // The “hello” message contains a send right to the child process’ task port. 37 // The “hello” message contains a send right to the child process’ task port.
37 struct SendHelloMessage : public mach_msg_base_t { 38 struct SendHelloMessage : public mach_msg_base_t {
38 mach_msg_port_descriptor_t port_descriptor; 39 mach_msg_port_descriptor_t port_descriptor;
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 MACH_PORT_NULL, 255 MACH_PORT_NULL,
255 MACH_MSG_TIMEOUT_NONE, 256 MACH_MSG_TIMEOUT_NONE,
256 MACH_PORT_NULL); 257 MACH_PORT_NULL);
257 ASSERT_EQ(MACH_MSG_SUCCESS, kr) << MachErrorMessage(kr, "mach_msg"); 258 ASSERT_EQ(MACH_MSG_SUCCESS, kr) << MachErrorMessage(kr, "mach_msg");
258 259
259 MachMultiprocessChild(); 260 MachMultiprocessChild();
260 261
261 info_->remote_port.reset(); 262 info_->remote_port.reset();
262 info_->local_port.reset(); 263 info_->local_port.reset();
263 264
265 // Close the write pipe now, for cases where the parent is waiting on it to
266 // be closed as an indication that the child has finished.
267 CloseWritePipe();
268
269 // Wait for the parent process to close its end of the pipe. The child process
270 // needs to remain alive until then because the parent process will attempt to
271 // verify it using the task port it has access to via ChildTask().
272 CheckedReadFDAtEOF(ReadPipeFD());
273
264 if (Test::HasFailure()) { 274 if (Test::HasFailure()) {
265 // Trigger the ScopedForbidReturn destructor. 275 // Trigger the ScopedForbidReturn destructor.
266 return; 276 return;
267 } 277 }
268 278
269 forbid_return.Disarm(); 279 forbid_return.Disarm();
270 } 280 }
271 281
272 } // namespace test 282 } // namespace test
273 } // namespace crashpad 283 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/test/multiprocess.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698