Issue 586053002: MachMultiprocess test: the child process must wait for the parent to finish

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 586053002: MachMultiprocess test: the child process must wait for the parent to finish (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

In MachMultiprocess-based tests, the child must wait for the parent to finish. It was possible for the child process to exit before the parent had a chance to complete the pid_for_task() portion of its verification. TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c93fcf82789d1073af9eef2e4a6dd17309c5d842

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -11 lines)			Patch
M	util/mach/mach_message_server_test.cc	View	1 2	3 chunks	+0 lines, -3 lines	0 comments	Download
M	util/test/mac/mach_multiprocess.cc	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	util/test/multiprocess.h	View	1 2	2 chunks	+22 lines, -0 lines	0 comments	Download
M	util/test/multiprocess.cc	View	1 2	3 chunks	+21 lines, -4 lines	0 comments	Download
M	util/test/multiprocess_test.cc	View	1 2	3 chunks	+160 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

Mark Mentovai

Hold off on this, I’m going to do it differently.

6 years, 3 months ago (2014-09-19 18:52:49 UTC) #2

Mark Mentovai

6 years, 3 months ago (2014-09-22 17:06:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as c93fcf8 (presubmit successful).