Move painting code from RenderLineBoxList to LineBoxListPainter.

Move painting code from RenderLineBoxList to LineBoxListPainter.

BUG=412088
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182374

[chrishtr, 2014-09-19 23:17:07]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[leviw_travelin_and_unemployed, 2014-09-19 23:18:57]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2014-09-19 23:18:57]

https://codereview.chromium.org/585943004/diff/1/Source/core/paint/LineBoxLis...
File Source/core/paint/LineBoxListPainter.h (right):

https://codereview.chromium.org/585943004/diff/1/Source/core/paint/LineBoxLis...
Source/core/paint/LineBoxListPainter.h:23: RenderLineBoxList&
m_renderLineBoxList;
This should be private.

[pdr., 2014-09-19 23:19:39]

LGTM2

https://codereview.chromium.org/585943004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLineBoxList.h (right):

https://codereview.chromium.org/585943004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLineBoxList.h:67: bool
anyLineIntersectsRect(RenderBoxModelObject*, const LayoutRect&, const
LayoutPoint&) const;
Can we use friend here and leave these private?

[chrishtr, 2014-09-19 23:19:48]

https://codereview.chromium.org/585943004/diff/1/Source/core/paint/LineBoxLis...
File Source/core/paint/LineBoxListPainter.h (right):

https://codereview.chromium.org/585943004/diff/1/Source/core/paint/LineBoxLis...
Source/core/paint/LineBoxListPainter.h:23: RenderLineBoxList&
m_renderLineBoxList;
On 2014/09/19 23:18:57, leviw wrote:
> This should be private.

Done.

[pdr., 2014-09-19 23:21:13]

On 2014/09/19 23:19:39, pdr wrote:
> LGTM2
> 
>
https://codereview.chromium.org/585943004/diff/1/Source/core/rendering/Render...
> File Source/core/rendering/RenderLineBoxList.h (right):
> 
>
https://codereview.chromium.org/585943004/diff/1/Source/core/rendering/Render...
> Source/core/rendering/RenderLineBoxList.h:67: bool
> anyLineIntersectsRect(RenderBoxModelObject*, const LayoutRect&, const
> LayoutPoint&) const;
> Can we use friend here and leave these private?

Talked offline, I think you took the right approach after all. Painting is now
public.

[chrishtr, 2014-09-20 21:34:00]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-20 21:34:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585943004/40001

[commit-bot: I haz the power, 2014-09-20 21:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 21:34:38]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pdr., 2014-09-20 21:42:14]

On 2014/09/20 21:34:38, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

LGTM

[pdr., 2014-09-20 21:42:46]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-09-20 21:43:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585943004/40001

[commit-bot: I haz the power, 2014-09-20 22:49:39]

Committed patchset #3 (id:40001) as 182374