Issue 58593003: Massage Autofill dialog sign in test to be more similar to actual sign in flow.

Issue 58593003: Massage Autofill dialog sign in test to be more similar to actual sign in flow. (Closed)

Created:
7 years, 1 month ago by Dan Beam

Modified:
7 years, 1 month ago

Reviewers:
Evan Stade

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Massage Autofill dialog sign in test to be more similar to actual sign in flow. R=estade@chromium.org BUG=314627 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232948

Patch Set 2 : merge #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -25 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc	View	1	5 chunks	+50 lines, -25 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm https://codereview.chromium.org/58593003/diff/30001/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/58593003/diff/30001/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc#newcode916 chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:916: controller()->OnUserNameFetchSuccess(usernames); I think it makes more sense to ...

7 years, 1 month ago (2013-11-05 00:02:19 UTC) #2

Dan Beam

https://codereview.chromium.org/58593003/diff/30001/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/58593003/diff/30001/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc#newcode916 chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:916: controller()->OnUserNameFetchSuccess(usernames); On 2013/11/05 00:02:20, Evan Stade wrote: > I ...

7 years, 1 month ago (2013-11-05 00:16:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/58593003/140001

7 years, 1 month ago (2013-11-05 01:36:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/58593003/140001

7 years, 1 month ago (2013-11-05 03:30:52 UTC) #5

Message was sent while issue was closed.

Change committed as 232948

Expand Messages | Collapse Messages