Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 585913004: mac: Fix key layout test on OSX 10.9+. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Fix key layout test on OSX 10.9+. The test NSMenuItemAdditionsTest.TestMOnDifferentLayouts was failing because a new French keyboard layout was added that the test logic failed to account for. BUG=390276 Committed: https://crrev.com/bdc7051b27478d02b6d88ebaf709819ccbe47282 Cr-Commit-Position: refs/heads/master@{#296115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
erikchen
avi: Please review.
6 years, 3 months ago (2014-09-19 22:24:11 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-20 01:05:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585913004/1
6 years, 3 months ago (2014-09-20 01:07:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585913004/1
6 years, 3 months ago (2014-09-20 01:07:45 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-20 03:08:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585913004/1
6 years, 3 months ago (2014-09-23 00:52:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as d6be8b05662a1eee98242137ad47ac1a3427a72d
6 years, 3 months ago (2014-09-23 00:54:12 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 00:55:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdc7051b27478d02b6d88ebaf709819ccbe47282
Cr-Commit-Position: refs/heads/master@{#296115}

Powered by Google App Engine
This is Rietveld 408576698