LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt - Issue 585873002: Show a warning when using sync xhr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated patch with reset -expected.txt files. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/get-dangerous-headers-expected.txt ('k') | LayoutTests/http/tests/xmlhttprequest/logout-expected.txt » ('j') | Source/core/dom/Document.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt

diff --git a/LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt b/LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt

index 29ce96c22a7023b2802118a7a2bd13842b78587f..6ebbd453408e3a812955c8f6837202894a6ba891 100644

--- a/LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt

+++ b/LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt

@@ -1,3 +1,4 @@

+CONSOLE WARNING: Avoid synchronous requests as it hampers user experience due to unresponsiveness of the web page. Refer https://xhr.spec.whatwg.org/#sync-warning.

Test that setRequestHeader properly checks for line feeds in header values.

%0AEvil%3A%20on -> SUCCESS, setRequestHeader() raised an exception SyntaxError: Failed to execute 'setRequestHeader' on 'XMLHttpRequest': ' Evil: on' is not a valid HTTP header field value.