Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated patch with reset -expected.txt files. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
diff --git a/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt b/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
index 37da73ff34ae0e179709b9541e4b57606fd5cf08..1eb247ef51becded43782716e598f98ac1a0076f 100644
--- a/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
+++ b/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
@@ -1,4 +1,5 @@
CONSOLE MESSAGE: line 10: sending a %s request to %s
+CONSOLE WARNING: Avoid synchronous requests as it hampers user experience due to unresponsiveness of the web page. Refer https://xhr.spec.whatwg.org/#sync-warning.
CONSOLE WARNING: Setting 'XMLHttpRequest.withCredentials' for synchronous requests is deprecated.
CONSOLE MESSAGE: line 10: sending a %s request to %s
CONSOLE MESSAGE: line 10: sending a %s request to %s
@@ -12,6 +13,7 @@ CONSOLE ERROR: XMLHttpRequest cannot load http://localhost:8000/inspector/resour
Tests that XMLHttpRequest Logging works when Enabled and doesn't show logs when Disabled.
console-xhr-logging.html:10 sending a GET request to resources/xhr-exists.html
+network-test.js:97 Avoid synchronous requests as it hampers user experience due to unresponsiveness of the web page. Refer https://xhr.spec.whatwg.org/#sync-warning.
network-test.js:98 Setting 'XMLHttpRequest.withCredentials' for synchronous requests is deprecated.
network-test.js:101 XHR finished loading: GET "http://127.0.0.1:8000/inspector/resources/xhr-exists.html".
console-xhr-logging.html:10 sending a GET request to resources/xhr-does-not-exist.html

Powered by Google App Engine
This is Rietveld 408576698