Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Document lifecycle enums used for beforeunload event tracking. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/UseCounter.cpp
diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp
index d5efd2996eefbec428364cabe4e2b475c345a49d..dbb76be4175d1f46761b9f8ed029b25f27a28860 100644
--- a/Source/core/frame/UseCounter.cpp
+++ b/Source/core/frame/UseCounter.cpp
@@ -792,6 +792,9 @@ String UseCounter::deprecationMessage(Feature feature)
case ConsoleTimelineEnd:
return "console.timelineEnd is deprecated. Please use the console.timeEnd instead.";
+ case XMLHttpRequestSynchronous:
+ return "Synchronous XMLHttpRequest is deprecated. Please use the async version.";
kouhei (in TOK) 2014/10/07 23:21:18 Is "deprecated" the message we want to show here?
Mayur Kankanwadi 2014/10/08 10:14:25 I assumed with UseCounter::countDeprecation functi
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();

Powered by Google App Engine
This is Rietveld 408576698