Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 585873002: Show a warning when using sync xhr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Document lifecycle enums used for beforeunload event tracking. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/Source/bindings/core/v8/V8AbstractEventListener.cpp b/Source/bindings/core/v8/V8AbstractEventListener.cpp

index 21be4e1c79935cc44ad2dfae3978b61b6b15a619..f2b37378296afdc86531092005be6cdb506e6e95 100644

--- a/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -124,7 +124,6 @@ void V8AbstractEventListener::invokeEventHandler(Event* event, v8::Local<v8::Val

// Make the event available in the global object, so LocalDOMWindow can expose it.

V8HiddenValue::setHiddenValue(isolate(), scriptState()->context()->Global(), V8HiddenValue::event(isolate()), jsEvent);

tryCatch.Reset();

kouhei (in TOK) 2014/10/07 23:21:18 Undo this change.

Mayur Kankanwadi 2014/10/09 14:37:55 Done.

returnValue = callListenerFunction(jsEvent, event);

if (tryCatch.HasCaught())

event->target()->uncaughtExceptionInEventHandler();